Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix typo in adapters.js #45515

Merged
merged 1 commit into from Nov 19, 2022
Merged

stream: fix typo in adapters.js #45515

merged 1 commit into from Nov 19, 2022

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Nov 19, 2022

isReadableNodestream -> isReadableNodeStream

@cola119
stream: fix typo in adapters.js
80d83f5 
isReadableNodestream -> isReadableNodeStream
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 19, 2022
@cola119 cola119 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @cola119. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 19, 2022
@aduh95 aduh95 merged commit 70305bb into nodejs:main Nov 19, 2022
@aduh95
Copy link
Contributor

aduh95 commented Nov 19, 2022

Landed in 70305bb

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@cola119 @ruyadorno
stream: fix typo in adapters.js (#45515)
496912d 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: #45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@cola119 @marco-ippolito
stream: fix typo in adapters.js (nodejs#45515)
d18a7cd 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: nodejs#45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cola119 @danielleadams
stream: fix typo in adapters.js (#45515)
54c7b94 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: #45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cola119 @danielleadams
stream: fix typo in adapters.js (#45515)
d655635 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: #45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@cola119 @danielleadams
stream: fix typo in adapters.js (#45515)
6f080e2 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: #45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@cola119 @danielleadams
stream: fix typo in adapters.js (#45515)
c5b6e9a 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: #45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@cola119 @danielleadams
stream: fix typo in adapters.js (#45515)
29647c8 
`isReadableNodestream` -> `isReadableNodeStream`

PR-URL: #45515
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeyeon daeyeon daeyeon approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cola119 @aduh95 @daeyeon @nodejs-github-bot