src: fix tls certificate root store data race #45767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
approved these changes
Dec 7, 2022
github-actions
bot
removed
the
request-ci
8 tasks
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently. This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function. Fixes: nodejs#45743
addaleax
approved these changes
Dec 8, 2022
github-actions
bot
removed
the
request-ci
This was referenced Dec 9, 2022
addaleax
added
the
author ready
This was referenced Dec 11, 2022
bnoordhuis
added
request-ci
github-actions
bot
removed
the
request-ci
bnoordhuis
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 273d869 |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently. This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function. Fixes: #45743 PR-URL: #45767 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently. This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function. Fixes: #45743 PR-URL: #45767 Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently. This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function. Fixes: #45743 PR-URL: #45767 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently.
This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function.
Fixes: #45743