Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add CryptoKey transferring tests #45811

Merged

Conversation

panva
Copy link
Member

@panva panva commented Dec 10, 2022

Extends the worker thread, message port, postMessage KeyObject tests to also cover CryptoKey instances.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 10, 2022
@panva
Copy link
Member Author

panva commented Dec 10, 2022

I recommend hiding whitespace changes for review.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2022
@panva panva force-pushed the add-cryptokey-transferrable-tests branch from 8e3a250 to 7941108 Compare December 11, 2022 21:11
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the crypto Issues and PRs related to the crypto subsystem. label Dec 13, 2022
@panva
Copy link
Member Author

panva commented Dec 13, 2022

cc @nodejs/crypto

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit 992fba4 into nodejs:main Dec 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 992fba4

@panva panva deleted the add-cryptokey-transferrable-tests branch December 16, 2022 19:59
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45811
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #45811
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants