Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix typo of return value #45991

Merged
merged 1 commit into from Dec 28, 2022
Merged

stream: fix typo of return value #45991

merged 1 commit into from Dec 28, 2022

Conversation

deokjinkim
Copy link
Contributor

Replace vois with void.

@deokjinkim
stream: fix typo of return value
39daf4a 
Replace `vois` with `void`.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Dec 28, 2022
@VoltrexKeyva VoltrexKeyva added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 28, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 28, 2022
@aduh95 aduh95 merged commit 0f23daa into nodejs:main Dec 28, 2022
@aduh95
Copy link
Contributor

aduh95 commented Dec 28, 2022

Landed in 0f23daa

targos pushed a commit that referenced this pull request Jan 1, 2023
@deokjinkim @targos
stream: fix typo in JSDoc
8e8f1d2 
`vois` -> `void`

PR-URL: #45991
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@deokjinkim @RafaelGSS
stream: fix typo in JSDoc
7d89e02 
`vois` -> `void`

PR-URL: #45991
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@deokjinkim @RafaelGSS
stream: fix typo in JSDoc
0858956 
`vois` -> `void`

PR-URL: #45991
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@deokjinkim @juanarbol
stream: fix typo in JSDoc
2c9b8c5 
`vois` -> `void`

PR-URL: #45991
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@deokjinkim @juanarbol
stream: fix typo in JSDoc
325fc08 
`vois` -> `void`

PR-URL: #45991
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deokjinkim @aduh95 @Trott @lpinca @anonrig @cjihrig @VoltrexKeyva @nodejs-github-bot