From 836554f18d4fe81c01e3a27626fdf0f96fb19831 Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Tue, 3 Jan 2023 16:19:57 +0530 Subject: [PATCH 1/5] doc: abort controller emits error in child process Fixes: https://github.com/nodejs/node/issues/46036 --- doc/api/child_process.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index f2f1755f4a9b2e..19110810ba1393 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -1189,6 +1189,7 @@ The `'error'` event is emitted whenever: 1. The process could not be spawned, or 2. The process could not be killed, or 3. Sending a message to the child process failed. +4. The child process is aborted via the AbortController and AbortError is passed into the callback The `'exit'` event may or may not fire after an error has occurred. When listening to both the `'exit'` and `'error'` events, guard From b9f14e479c7012a0212fa64b048d3cb8b34bf8bf Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Tue, 3 Jan 2023 16:20:41 +0530 Subject: [PATCH 2/5] fixup --- doc/api/child_process.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index 19110810ba1393..6ab57d757a4d0e 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -1188,8 +1188,8 @@ The `'error'` event is emitted whenever: 1. The process could not be spawned, or 2. The process could not be killed, or -3. Sending a message to the child process failed. -4. The child process is aborted via the AbortController and AbortError is passed into the callback +3. Sending a message to the child process failed, or +4. The child process is aborted via the AbortController and AbortError is passed into the callback. The `'exit'` event may or may not fire after an error has occurred. When listening to both the `'exit'` and `'error'` events, guard From fc0580e5f70851d567e77ab09f70c65158e08dbf Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Tue, 3 Jan 2023 16:24:28 +0530 Subject: [PATCH 3/5] fixup --- doc/api/child_process.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index 6ab57d757a4d0e..d0e5019ffed9c3 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -1189,7 +1189,7 @@ The `'error'` event is emitted whenever: 1. The process could not be spawned, or 2. The process could not be killed, or 3. Sending a message to the child process failed, or -4. The child process is aborted via the AbortController and AbortError is passed into the callback. +4. The child process is aborted via the `AbortController` (`AbortError` is passed into the callback). The `'exit'` event may or may not fire after an error has occurred. When listening to both the `'exit'` and `'error'` events, guard From 29e68ad6dd47fc0caf305527ccc5de5b4e2951b5 Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Tue, 3 Jan 2023 22:44:51 +0530 Subject: [PATCH 4/5] fixup! make list compliant with standards --- doc/api/child_process.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index d0e5019ffed9c3..220f3a2404d9e3 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -1186,10 +1186,10 @@ property is `false`. The `'error'` event is emitted whenever: -1. The process could not be spawned, or -2. The process could not be killed, or -3. Sending a message to the child process failed, or -4. The child process is aborted via the `AbortController` (`AbortError` is passed into the callback). +- The process could not be spawned. +- The process could not be killed. +- Sending a message to the child process failed. +- The child process was aborted via the `signal` option. The `'exit'` event may or may not fire after an error has occurred. When listening to both the `'exit'` and `'error'` events, guard From 9b2b3b64f73cf1f9cdaccbc5b99ec07479ea4da3 Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Tue, 3 Jan 2023 22:56:41 +0530 Subject: [PATCH 5/5] fixup! fix md formatting --- doc/api/child_process.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index 220f3a2404d9e3..70345e9472c66e 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -1186,10 +1186,10 @@ property is `false`. The `'error'` event is emitted whenever: -- The process could not be spawned. -- The process could not be killed. -- Sending a message to the child process failed. -- The child process was aborted via the `signal` option. +* The process could not be spawned. +* The process could not be killed. +* Sending a message to the child process failed. +* The child process was aborted via the `signal` option. The `'exit'` event may or may not fire after an error has occurred. When listening to both the `'exit'` and `'error'` events, guard