vm: refactor to use validate function #46176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Throwing error after checking type is repeated. So replace it with validate function.
deokjinkim
force-pushed
the
230112_vm_refactor_validate
branch
from
8cc4aed
to
a31a02a
Compare
VoltrexKeyva
approved these changes
Jan 12, 2023
aduh95
approved these changes
Jan 12, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
jasnell
approved these changes
Jan 13, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 36d54dc |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Throwing error after checking type is repeated. So replace it with validate function. PR-URL: nodejs#46176 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Throwing error after checking type is repeated. So replace it with validate function. PR-URL: #46176 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Throwing error after checking type is repeated. So replace it with validate function. PR-URL: #46176 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Throwing error after checking type is repeated. So replace it with validate function. PR-URL: #46176 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing error after checking type is repeated.
So replace it with validate function.