Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toLocaleTimeString regression in v18 #46571

Closed
chernodub opened this issue Feb 8, 2023 · 2 comments
Closed

toLocaleTimeString regression in v18 #46571

chernodub opened this issue Feb 8, 2023 · 2 comments
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@chernodub
Copy link

Version

v18.14.0

Platform

Darwin MacBook-Pro.local 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct 9 20:15:09 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T6000 arm64

Subsystem

No response

What steps will reproduce the bug?

  1. Run node
  2. Log new Date().toLocaleTimeString('en').charCodeAt(7) to see the char code of the space
  3. See the result, it's 8239

How often does it reproduce? Is there a required condition?

100% of runs

What is the expected behavior?

The code of the space here should supposably be 32, at least that's what I see when running in Chrome 109.0.5414.119 and Node v16.19.0.

What do you see instead?

The code of the space is - 8239

Additional information

This causes issues when running hydration in NextJS.
@targos
Copy link
Member

targos commented Feb 8, 2023

This is a duplicate of #46123. Chrome 110 (now stable) has the same behavior.

@targos targos closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
@targos targos added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Feb 8, 2023
@chernodub
Copy link
Author

Thanks for clarifying @targos

@targos targos mentioned this issue Mar 13, 2023
Closed
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Apr 2, 2023
@RafaelGSS RafaelGSS mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @danielleadams @chernodub