From ad295e21e570a3569db9339fc429b217627df2e3 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 18 Mar 2024 20:30:54 +0000 Subject: [PATCH 1/2] src: address coverity warning in module_wrap.cc - remove copying as suggested by coverity Signed-off-by: Michael Dawson --- src/module_wrap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/module_wrap.cc b/src/module_wrap.cc index 92b34f5a8b99c2..11817aa7b618b2 100644 --- a/src/module_wrap.cc +++ b/src/module_wrap.cc @@ -128,7 +128,7 @@ v8::Maybe ModuleWrap::CheckUnsettledTopLevelAwait() { } if (env()->options()->warnings) { - for (auto pair : stalled) { + for (auto & pair : stalled) { Local message = std::get<1>(pair); std::string reason = "Warning: Detected unsettled top-level await at "; From 075a3fc5fa2a5c062b7876f341bef374c0afb832 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 18 Mar 2024 20:40:58 +0000 Subject: [PATCH 2/2] squash: make linter happy Signed-off-by: Michael Dawson --- src/module_wrap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/module_wrap.cc b/src/module_wrap.cc index 11817aa7b618b2..bb85e69b5fe3d4 100644 --- a/src/module_wrap.cc +++ b/src/module_wrap.cc @@ -128,7 +128,7 @@ v8::Maybe ModuleWrap::CheckUnsettledTopLevelAwait() { } if (env()->options()->warnings) { - for (auto & pair : stalled) { + for (auto& pair : stalled) { Local message = std::get<1>(pair); std::string reason = "Warning: Detected unsettled top-level await at ";