Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-35256 (llhttp) found on v14.x #92

Closed
github-actions bot opened this issue Dec 9, 2022 · 7 comments
Closed

CVE-2022-35256 (llhttp) found on v14.x #92

github-actions bot opened this issue Dec 9, 2022 · 7 comments

Comments

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

A new vulnerability for llhttp 2.1.6 was found:
Vulnerability ID: CVE-2022-35256
Vulnerability URL: https://nvd.nist.gov/vuln/detail/CVE-2022-35256
Failed run: https://github.com/nodejs/nodejs-dependency-vuln-assessments/actions/runs/3653206934

@github-actions github-actions bot added the v14.x label Dec 9, 2022
@richardlau
Copy link
Member

Any idea why this has just popped up now? FWIW I'm preparing a Node.js 14 release for Tuesday but there are no llhttp commits in the proposal: nodejs/node#45775

@richardlau
Copy link
Member

Is this an error in https://nvd.nist.gov/vuln/detail/CVE-2022-35256?
image

Maybe stemming from https://nodejs.org/en/blog/vulnerability/september-2022-security-releases/#http-request-smuggling-due-to-incorrect-parsing-of-header-fields-medium-cve-2022-35256?

llhttp v6.0.10 contains the fixes that were updated inside Node.js

Node.js was updated to llhttp 2.1.6 by nodejs/node@a9f1146 as part of those same security releases. I believe there were semver reasons why Node.js 14 is not on a later llhttp semver major.

@RafaelGSS
Copy link
Member

cc: @ShogunPanda

@mcollina
Copy link
Member

My understanding is that there is a mistake on that CVE as llhttp v2.1.6 contains those fixes.

@mhdawson
Copy link
Member

We have asked how we get the CVE updated, but based on our understanding as outlined by @mcollina above this does not affect current Node.js versions.

@ShogunPanda
Copy link

Node 14 uses llhttp 2.1.x so I confirm this is not valid.

@mhdawson
Copy link
Member

mhdawson commented May 1, 2023

Closing out as 14.x is EOL

@mhdawson mhdawson closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants