Is ERR_MULTIPLE_CALLBACK missing a new?

[Jarred-Sumner]

ERR_MULTIPLE_CALLBACK is an Error subclass (eventually) defined here:

readable-stream/lib/ours/errors.js

Lines 70 to 97 in a2e9aed

	class NodeError extends Base {
	constructor(...args) {
	super(getMessage(code, message, args))
	}
	toString() {
	return `${this.name} [${code}]: ${this.message}`
	}
	}
	Object.defineProperties(NodeError.prototype, {
	name: {
	value: Base.name,
	writable: true,
	enumerable: false,
	configurable: true
	},
	toString: {
	value() {
	return `${this.name} [${code}]: ${this.message}`
	},
	writable: true,
	enumerable: false,
	configurable: true
	}
	})
	NodeError.prototype.code = code
	NodeError.prototype[kIsNodeError] = true
	codes[code] = NodeError
	}

In this line, ERR_MULTIPLE_CALLBACK is called instead of constructed:

readable-stream/lib/internal/streams/writable.js

Line 594 in a2e9aed

errorOrDestroy(stream, err !== null && err !== undefined ? err : ERR_MULTIPLE_CALLBACK())

I ran into this in a difficult to isolate scenario

[vweevers]

Looks like a bug in Node.js: https://github.com/nodejs/node/blob/10c6596f6d7abf7451112e767f8277fcd276d796/lib/internal/streams/writable.js#L879

[mcollina]

@Jarred-Sumner would you like to send a PR? We can't do much about the Node.js source, and we should adapt the code in ours/errors.js to be spawned without new.

A test to repro this would be nice.

[vweevers]

nodejs/node#52110