Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"blocking" missing from dispatcher type definition #1885

Closed
xconverge opened this issue Jan 25, 2023 · 2 comments · Fixed by #1889
Closed

"blocking" missing from dispatcher type definition #1885

xconverge opened this issue Jan 25, 2023 · 2 comments · Fixed by #1889
Labels
bug Something isn't working

Comments

@xconverge
Copy link
Contributor

xconverge commented Jan 25, 2023

Bug Description

a blocking flag was added in https://github.com/nodejs/undici/pull/1034/files but was not added to https://github.com/nodejs/undici/blob/main/types/dispatcher.d.ts

I am not super clear on what this flag does/prevents/changes but wanted to try it for a long running request I am having issues with

Reproducible By

Examination

Expected Behavior

Type should exist

@xconverge xconverge added the bug Something isn't working label Jan 25, 2023
@xconverge
Copy link
Contributor Author

xconverge commented Jan 25, 2023

I can open a PR if its just adding the one line to the file? But I was also wondering if I could get a sentence on what this is doing, if the comment in the docs is accurate then I am good

* **blocking** `boolean` (optional) - Default: `false` - Whether the response is expected to take a long time and would end up blocking the pipeline. When this is set to `true` further pipelining will be avoided on the same connection until headers have been received.

@xconverge xconverge changed the title blocking missing from dispatcher type definition "blocking" missing from dispatcher type definition Jan 26, 2023
@xconverge xconverge changed the title "blocking" missing from dispatcher type definition "blocking" and "throwOnError" missing from dispatcher type definition Jan 26, 2023
@xconverge xconverge changed the title "blocking" and "throwOnError" missing from dispatcher type definition "blocking" missing from dispatcher type definition Jan 26, 2023
@mcollina
Copy link
Member

the comment on the doc is accurate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants