Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Errors documentation is missing 6 errors from table list #2090

Closed
titanism opened this issue Apr 24, 2023 · 4 comments · Fixed by #2092
Closed

docs: Errors documentation is missing 6 errors from table list #2090

titanism opened this issue Apr 24, 2023 · 4 comments · Fixed by #2092
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@titanism
Copy link
Contributor

The following errors are not documented at https://github.com/nodejs/undici/blob/main/docs/api/Errors.md:

  • UND_ERR
  • UND_ERR_CONNECT_TIMEOUT
  • UND_ERR_HEADERS_TIMEOUT
  • UND_ERR_HEADERS_OVERFLOW
  • UND_ERR_BODY_TIMEOUT
  • UND_ERR_RESPONSE_STATUS_CODE
@titanism titanism added the enhancement New feature or request label Apr 24, 2023
@ronag
Copy link
Member

ronag commented Apr 24, 2023

PR welcome

@ronag ronag added the good first issue Good for newcomers label Apr 24, 2023
@ronag
Copy link
Member

ronag commented Apr 24, 2023

I don't know about UND_ERR? I don't think we ever throw that.

@titanism
Copy link
Contributor Author

@ronag It is used, but only by mock agent at:

throw new UndiciError(`
${pluralizer.count} ${pluralizer.noun} ${pluralizer.is} pending:
${pendingInterceptorsFormatter.format(pending)}
`.trim())

@ronag We are submitting PR now, one moment!

titanism added a commit to titanism/undici that referenced this issue Apr 24, 2023
@titanism
Copy link
Contributor Author

@ronag see #2092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants