Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Update broke test/fetch/pull-dont-push.js? #2697

Closed
Uzlopak opened this issue Feb 5, 2024 · 6 comments · Fixed by #2699
Closed

Security Update broke test/fetch/pull-dont-push.js? #2697

Uzlopak opened this issue Feb 5, 2024 · 6 comments · Fixed by #2699
Labels
bug Something isn't working

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 5, 2024

The unit test test/fetch/pull-dont-push.js is broken. I first thought it has something to do within my PR #2696 were I saw this first. But this issue is also on the default branch. I deleted locally my undici repo, cloned again and again the test runner hangs on this specific test.

I guess it has something to do with the security patches.

@Uzlopak Uzlopak added the bug Something isn't working label Feb 5, 2024
@mcollina
Copy link
Member

mcollina commented Feb 5, 2024

That test was added by the security release and it's passing on main. Where is it failing?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 5, 2024

@mcollina
Like i said, my pr is failing because if this file. And when i clone this repo fresh and use the main branch and install everything etc.. then this test is never ending?!

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 5, 2024

@mcollina
See #2698

@mcollina
Copy link
Member

mcollina commented Feb 5, 2024

The tests seems to be passing on main. Or maybe they are not run at all?

On Mac the test pass on all version.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 5, 2024

This one PR I created is just adding an .npmrc file and the CI/CD pipeline is broken?!

Maybe one of the commits merged after the security release broke it?

I will investigate in few hours.

@mcollina
Copy link
Member

mcollina commented Feb 5, 2024

Here is the fix: #2699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants