Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musl Contains a Security Issue up to v1.2.1 #25

Closed
zFlux opened this issue Mar 16, 2021 · 2 comments
Closed

Musl Contains a Security Issue up to v1.2.1 #25

zFlux opened this issue Mar 16, 2021 · 2 comments

Comments

@zFlux
Copy link

zFlux commented Mar 16, 2021

According to openwall musl contains a security bug up to v1.2.1 that needs patching or update to > v1.2.2

@rvagg
Copy link
Member

rvagg commented Mar 18, 2021

This function is not used internally in musl and is not widely used, but does appear in some applications

It'd be interesting to find out if it appears in our binaries at all.

I don't think this is a major issue for us anyway, since this exists in musl and I don't think we're shipping anything static such that we're shipping code with an insecure implementation, rather that the library it calls contains an insecure implementation so it's the host that needs to be updated.

But, we're still building with Alpine 3.9 and should probably upgrade anyway. For now I've just flushed out all of the images that do the build and recreated them, so we've gone from:

musl-1.1.20-r4 x86_64 {musl} (MIT) [installed]

To:

musl-1.1.20-r6 x86_64 {musl} (MIT) [installed]

Its release date @ https://pkgs.alpinelinux.org/package/v3.9/main/x86_64/musl matches the wcsnrtombs-cve-2020-28928 commit @ https://git.alpinelinux.org/aports/log/main/musl?h=3.9-stable so I suppose that's included.

I've made an issue suggesting we upgrade all our Alpine images to a newer version, but I think this is a side issue to your original, so I'll close this for now (but let me know if you disagree with the resolution). #26

@rvagg rvagg closed this as completed Mar 18, 2021
@rvagg
Copy link
Member

rvagg commented Mar 18, 2021

also, thanks for notifying us! this wasn't on my radar at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants