Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fs.walk] Explore fs.opendir #46

Closed
mrmlnc opened this issue Oct 9, 2019 · 2 comments
Closed

[fs.walk] Explore fs.opendir #46

mrmlnc opened this issue Oct 9, 2019 · 2 comments
Assignees
@mrmlnc
Labels
Library: FileSystem Type: Need more details

Comments

@mrmlnc
Copy link
Contributor

mrmlnc commented Oct 9, 2019 •
edited

nodejs/node#29349
nodejs/node#29941
@mrmlnc mrmlnc self-assigned this Oct 9, 2019
@Fishrock123
Copy link

The perf issue should now be alleviated mostly by default, and if you want to optimize, an option for the number of buffered entries can be specified as of nodejs/node#30114, to be in the next release.

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Jan 16, 2022

The current implementation of opendir is twice as slow (1.8ms vs 0.8ms) for traversing the directory. This is more suitable for traversing large directories, but not for a universal tool.

@mrmlnc mrmlnc closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrmlnc mrmlnc

Labels
Library: FileSystem Type: Need more details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fishrock123 @mrmlnc