New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for URL uses "path" instead of "href" #13

Open

Damarowsky opened this issue Sep 30, 2019 · 0 comments

Damarowsky commented Sep 30, 2019

In the provided example "path" is used instead of "href". This resulted in a slight confusion when trying to implement an attachment with an URL.

{   // use URL as an attachment
            filename: 'license.txt',
            path: 'https://raw.github.com/nodemailer/nodemailer/master/LICENSE'
},

should be

{   // use URL as an attachment
            filename: 'license.txt',
            href: 'https://raw.github.com/nodemailer/nodemailer/master/LICENSE'
},

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment