Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many unauthenticated commands while authOptional is true #164

Open
jaspervann opened this issue Apr 29, 2021 · 1 comment
Open

Too many unauthenticated commands while authOptional is true #164

jaspervann opened this issue Apr 29, 2021 · 1 comment

Comments

@jaspervann
Copy link

The following line should check for this._server.options.authOptional, because if authOptional option is set to true, there may be infinite unauthenticated commands:

if (!this.session.user && this._isSupported('AUTH') && commandName !== 'AUTH' && this._maxAllowedUnauthenticatedCommands !== false) {

Currently even whilst you set authOptional to true, the server will throw a "421 - Error: too many unauthenticated commands" after receiving _maxAllowedUnauthenticatedCommands unauthenticated commands. That's not desirable, because authentication in this case was not required.

@jaspervann
Copy link
Author

The solution to issue #161 also resolves this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant