Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide configuration info for disabled protocol #19

Open
JokerQyou opened this issue May 12, 2019 · 1 comment
Open

Hide configuration info for disabled protocol #19

JokerQyou opened this issue May 12, 2019 · 1 comment

Comments

@JokerQyou
Copy link

The webmail uses a standalone configuration file (default.toml), there is this section which controls the configuration info shown in /help page:

[setup]
    # these values are shown in the configuration help page
    [setup.imap]
        hostname="localhost"
        secure=true
        port=9993
    [setup.pop3]
        hostname="localhost"
        secure=true
        port=9995
    [setup.smtp]
        hostname="localhost"
        secure=false
        port=2587

But if POP3 is disabled, the webmail would not know, and still displays those info in /help page.

I would like to suggest adding a disabled key to the [setup.*] section, and hide the corresponding info:

    [setup.pop3]
        disabled=true
@laurivosandi
Copy link
Contributor

Feel free to implement PR with some if statements https://github.com/nodemailer/wildduck-webmail/blob/master/views/help.hbs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants