Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/get-port@4.2.0 dependency is deprecated #298

Closed
lafeuil opened this issue Apr 6, 2020 · 2 comments · Fixed by #328
Closed

@types/get-port@4.2.0 dependency is deprecated #298

lafeuil opened this issue Apr 6, 2020 · 2 comments · Fixed by #328

Comments

@lafeuil
Copy link
Contributor

lafeuil commented Apr 6, 2020

Versions

  • NodeJS: 12
  • mongodb-memory-server-*: 6.5.2
  • mongodb: 4.2-next
  • system: Linux

package: mongo-memory-server

What is the Problem?

After installing the mongo-memory-server, I have this deprecated warning :

npm WARN deprecated @types/get-port@4.2.0: This is a stub types definition. get-port provides its own type definitions, so you do not need this installed.

This dependency is in mongodb-memory-server-core package.

$ npm ls @types/get-port
[...]
└─┬ mongodb-memory-server@6.5.2
  └─┬ mongodb-memory-server-core@6.5.2
    └── @types/get-port@4.2.0 

Do you know why it happenes?

no

@lafeuil lafeuil added the bug label Apr 6, 2020
@lafeuil
Copy link
Contributor Author

lafeuil commented Apr 6, 2020

I don't check but I think you can remove this dependency because the types definition are defined in the main package get-port.

@hasezoey
Copy link
Member

@lafeuil it will get removed once we move from get-port to portfinder #287

@hasezoey hasezoey added enhancement and removed bug labels Apr 13, 2020
nodkz pushed a commit that referenced this issue Jul 28, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
closes #298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants