Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match README description for checkMD5 #342

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Conversation

jpumford
Copy link
Contributor

This PR updates the code to follow the README.

I noticed the checkMD5 option was not available on the MongoMemoryServer class constructor, though the README indicated it is an option.

Here's a quick PR passing through the option to do an MD5 check for the downloaded mongo binary.

I also added two quick log statements in the MD5 check function. If that's a problem I can take them out, but they were useful to me and may be useful to someone else running in debug mode.

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #342 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   78.66%   78.73%   +0.06%     
==========================================
  Files           9        9              
  Lines         928      931       +3     
  Branches      265      266       +1     
==========================================
+ Hits          730      733       +3     
+ Misses        197      196       -1     
- Partials        1        2       +1     
Impacted Files Coverage Δ
...mongodb-memory-server-core/src/util/MongoBinary.ts 77.10% <100.00%> (+0.27%) ⬆️
...memory-server-core/src/util/MongoBinaryDownload.ts 75.12% <100.00%> (+0.26%) ⬆️
...ongodb-memory-server-core/src/MongoMemoryServer.ts 92.07% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc11fe...6f8d534. Read the comment docs.

@nodkz nodkz merged commit d2c6cc0 into typegoose:master Aug 25, 2020
@nodkz
Copy link
Collaborator

nodkz commented Aug 25, 2020

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants