Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is "Quick view" description in doc / overview.md still valid? #552

Closed
ohnewein opened this issue Mar 29, 2024 · 9 comments
Closed

Is "Quick view" description in doc / overview.md still valid? #552

ohnewein opened this issue Mar 29, 2024 · 9 comments
Assignees
@sseppi
Labels
documentation Improvements or additions to documentation
Milestone
Data Browser 2.5 ...

Comments

@ohnewein
Copy link
Member

Should this paragraph been removed? Do we still have the "Quick view"?

  • Quick view: The quick view is a user-friendly interface that provides a concise and summary-based overview of a record, highlighting the most important attributes. It aims to present key information in a visually appealing and easily digestible format.

https://github.com/noi-techpark/it.bz.opendatahub.databrowser/blob/development/doc/overview.md#visualization
@ohnewein ohnewein added the documentation Improvements or additions to documentation label Mar 29, 2024
@gappc
Copy link
Collaborator

gappc commented Apr 7, 2024

@ohnewein @sseppi @mrabans technically, we still have the Quick view and it is used for datasets of type ODHActivityPoi.

You can see that there is a button on the left of ODHActivityPoi table view that opens the Quick view (https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/ODHActivityPoi).

image

Unfortunately, there seems to be a fresh bug in the Quick view, because it fails to show data when opened (e.g. https://databrowser.opendatahub.testingmachine.eu/dataset/quick/tourism/v1/ODHActivityPoi/smgpoifad01289740e1d2f58dc1aa29288bb33). The bug seems related to the Leaflet library that is used to show maps. I didn't take a look at it yet, because I'm not sure if the Quick view remains in place.

We should decide if we want to keep the Quick view. If it turns out that we want to keep it, we should plan what to do with this feature, because at the moment it is half-complete (ODHActivityPoi only). If it turns out that we don't need the Quick view, then I think it would be best to remove the feature and stuff related to it.

@ohnewein
Copy link
Member Author

ohnewein commented Apr 7, 2024

My suggestion would be to reduce complexity. If there are no users requesting it, I would remove it.

@sseppi
Copy link
Contributor

sseppi commented Apr 8, 2024

@gappc

My suggestion would be to reduce complexity. If there are no users requesting it, I would remove it.

I agree with Patrick, let remove it. If users will ask for it, we will fix the bug and publish it again.

gappc added a commit that referenced this issue Apr 14, 2024
@gappc
Remove Quick View and related facilities
b33986f 
The Quick View was intended to provide a nice overview over datasets.

Implemented for the ODHActivityPoi datasets, it turned out that the Quick View it is not needed
at the moment (see issue #552 on GitHub).

Therefor, this commit removes all of the Quick View related code and configs and moves / renames
the shared stuff that is still used to other locations.
@gappc gappc mentioned this issue Apr 14, 2024
Merged
@gappc
Copy link
Collaborator

gappc commented Apr 14, 2024

@ohnewein @sseppi PR #559 removes the Quick View

@sseppi
Copy link
Contributor

sseppi commented Apr 15, 2024

@ohnewein @sseppi PR #559 removes the Quick View

@gappc Perfect! Thank you! Is the PR ready to be merged?

@gappc
Copy link
Collaborator

gappc commented Apr 15, 2024

@sseppi yes it is ready

@gappc
Copy link
Collaborator

gappc commented Apr 21, 2024

@ohnewein @sseppi @RudiThoeni the Quick View was removed as of commit 339544c

If it's ok with you, we could close this issue.

@sseppi sseppi added this to the Data Browser 2.5 - Beta milestone Apr 22, 2024
@sseppi
Copy link
Contributor

sseppi commented Apr 22, 2024

@RudiThoeni did you deploy this update also on production?

@RudiThoeni
Copy link
Member

@sseppi no i wanted to do a production deploy today

@sseppi sseppi closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sseppi sseppi

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Data Browser 2.5 - Beta
Development

No branches or pull requests
4 participants
@ohnewein @gappc @sseppi @RudiThoeni