Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-nom-app fails to commit to git when GPG signing fails #108

Open
MaximDevoir opened this issue Dec 19, 2019 · 0 comments
Open

create-nom-app fails to commit to git when GPG signing fails #108

MaximDevoir opened this issue Dec 19, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@MaximDevoir
Copy link
Collaborator

MaximDevoir commented Dec 19, 2019

A Git repo is only partially initialized when GPG signing fails (e.g. the user closes the prompt for signing with a GPG key).

The Git repo is there, but no files are staged or committed.

Possible Solution

If the app fails to commit: stage the files and log a message; something along the lines of:

A Git repository was initialized but Create Nom App was unable to create a commit. The files have been staged for committing later.

@MaximDevoir MaximDevoir added the bug Something isn't working label Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Pre-Next Major
  
Awaiting triage
Development

No branches or pull requests

1 participant