Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jest as a test engine #3

Open
MaximDevoir opened this issue Jul 13, 2019 · 2 comments
Open

Add Jest as a test engine #3

MaximDevoir opened this issue Jul 13, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@MaximDevoir
Copy link
Collaborator

MaximDevoir commented Jul 13, 2019

Add support for the Jest engine and enable Mocha and Jest tests to work seamlessly together.

@MaximDevoir MaximDevoir added the bug Something isn't working label Jul 13, 2019
@MaximDevoir MaximDevoir self-assigned this Jul 13, 2019
@MaximDevoir MaximDevoir added this to To do in v0.2.0 Jul 14, 2019
@MaximDevoir MaximDevoir added enhancement New feature or request and removed bug Something isn't working labels Jul 14, 2019
@MaximDevoir MaximDevoir changed the title Switch test engine to jest Add test engine to jest Jul 21, 2019
@MaximDevoir MaximDevoir changed the title Add test engine to jest Add Jest as a test engine Jul 21, 2019
@MaximDevoir MaximDevoir removed this from To do in v0.2.0 Jul 21, 2019
@MaximDevoir MaximDevoir added this to To do in Pre-Next Major Jul 23, 2019
@MaximDevoir MaximDevoir moved this from To do to Done in Pre-Next Major Jul 23, 2019
@MaximDevoir MaximDevoir moved this from Done to To do in Pre-Next Major Jul 23, 2019
@MaximDevoir MaximDevoir removed this from To do in Pre-Next Major Jul 23, 2019
@MaximDevoir MaximDevoir added this to To do in Pre-Next Major Aug 19, 2019
@MaximDevoir
Copy link
Collaborator Author

Differentiate Jest and Mocha tests by the an infix.

Mocha filename format would be name.spec.ext

Jest filename format would be name.test.ext

@MaximDevoir
Copy link
Collaborator Author

I think we should support Jest out-of-the-box and drop support for Mocha. Right now, supporting the Mocha and Jest test engines is too much to maintain.

If there is a demand for supporting Mocha as a test engine, then we can look into re-adding and maintaining another test engine.

I still think we should follow the filenaming conventions mentioned above to future-proof Mocha integration into CNA.

In the meantime, users who prefer to use Mocha can add mocha to their project's dependencies and replace their test script from nom-scripts test to point to the mocha binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Pre-Next Major
  
To do
Development

No branches or pull requests

1 participant