Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meander.interpreter.epsilon/finder doesn't work with multiple clauses #229

Open
prepor opened this issue Feb 16, 2022 · 1 comment
Open

meander.interpreter.epsilon/finder doesn't work with multiple clauses #229

prepor opened this issue Feb 16, 2022 · 1 comment

Comments

@prepor
Copy link

prepor commented Feb 16, 2022

Hi.

[query f & more-clauses] args version of finder calls finder-from with a collection of pairs while finder-from expects clauses list and partition it by itself.

And there is no single test for meander.interpreter.epsilon/finder with multiple clauses.

The fix is simple:
Instead of (finder-from (cons [query f] (partition 2 more-clauses))) we can (finder-from (cons query (cons f more-clauses)))

I can prepare a PR if it would help
@noprompt
Copy link
Owner

I can prepare a PR if it would help

Yes. Please!

@ZehCnaS34 ZehCnaS34 mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prepor @noprompt