Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted search result is hard to read #250

Open
zasdaym opened this issue Jul 30, 2022 · 3 comments
Open

Highlighted search result is hard to read #250

zasdaym opened this issue Jul 30, 2022 · 3 comments

Comments

@zasdaym
Copy link

zasdaym commented Jul 30, 2022

Description

The highlighted search result (especially the icon on the right) is hard to read because it does not contrast enough with the background color.

Screen Shot 2022-07-31 at 04 48 49

@svengreb
Copy link
Member

svengreb commented Aug 4, 2022

Hi @zasdaym 👋

The customization of icon styles like the color is only possible as of the latest versions, but I need more time to get into the API to adapt it for Nord. I'm also not sure if it is possible to style every icon and also cover every use case where and how the context the icon is placed is important, e.g. in specific states when hovered or focused. Another problem is that users can install custom icon themes which makes it impossible to support anything else but only the bundled default theme(s).

The problem has also been reported in #156, #146 and many other (closed) issues and I replied with a statement comment in #156 about the planned changes. Please also subscribe to this issue to get notified about further updates.

@zasdaym
Copy link
Author

zasdaym commented Aug 10, 2022

Thanks for the answer @svengreb

I temporarily solved this issue by adding this to my VSCode settings:

  "workbench.colorCustomizations": {
    "quickInputList.focusBackground": "#3b4252",
    "quickInputList.focusForeground": "#d8dee9"
  }

Result:
Screen Shot 2022-08-10 at 19 36 34

@svengreb
Copy link
Member

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@zasdaym Thanks again for your contribution 🚀
The issue has been added for triage and the review will be planned for the next iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: triage
Development

No branches or pull requests

2 participants