From 8bb201129e35f6f3c2852c426f71606133cb187e Mon Sep 17 00:00:00 2001 From: John Norwood Date: Sun, 4 Oct 2020 00:36:24 +0000 Subject: [PATCH] fix: makes it so charts with empty values files still get helm-docs-version footers --- .pre-commit-config.yaml | 2 +- pkg/document/model.go | 1 + pkg/document/template.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3022f5b..dae67c0 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -6,5 +6,5 @@ repos: args: - --chart-search-root=example-charts - --template-files=./_templates.gotmpl - - --template-files=README.gotmpl + - --template-files=README.md.gotmpl - --log-level=debug diff --git a/pkg/document/model.go b/pkg/document/model.go index 91c921c..89f17da 100644 --- a/pkg/document/model.go +++ b/pkg/document/model.go @@ -28,6 +28,7 @@ func getChartTemplateData(chartDocumentationInfo helm.ChartDocumentationInfo, he if chartDocumentationInfo.ChartValues.Kind == 0 { return chartTemplateData{ ChartDocumentationInfo: chartDocumentationInfo, + HelmDocsVersion: helmDocsVersion, Values: make([]valueRow, 0), }, nil } diff --git a/pkg/document/template.go b/pkg/document/template.go index 3ca539b..5bebe67 100644 --- a/pkg/document/template.go +++ b/pkg/document/template.go @@ -215,7 +215,7 @@ func getHelmDocsVersionTemplates() string { versionSectionBuilder := strings.Builder{} versionSectionBuilder.WriteString(`{{ define "helm-docs.version" }}{{ if .HelmDocsVersion }}{{ .HelmDocsVersion }}{{ end }}{{ end }}`) versionSectionBuilder.WriteString(`{{ define "helm-docs.versionFooter" }}`) - versionSectionBuilder.WriteString("\n{{ if .HelmDocsVersion }}\n") + versionSectionBuilder.WriteString("{{ if .HelmDocsVersion }}\n") versionSectionBuilder.WriteString("----------------------------------------------\n") versionSectionBuilder.WriteString("Autogenerated from chart metadata using [helm-docs v{{ .HelmDocsVersion }}](https://github.com/norwoodj/helm-docs/releases/v{{ .HelmDocsVersion }})") versionSectionBuilder.WriteString("{{ end }}")