Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: git-hook #221

Open
DrummyFloyd opened this issue Feb 29, 2024 · 3 comments
Open

[Feat]: git-hook #221

DrummyFloyd opened this issue Feb 29, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request triage Issues that need to be triaged and categorized

Comments

@DrummyFloyd
Copy link

General Summary

shoudl be great to have in the script, the installation of the wanted binary, instead of the script that say ,
please install it

echo "Please install helm-docs to run the pre-commit hook! https://github.com/norwoodj/helm-docs#installation"

based on the rev wanted by pre-commit

Is your feature request related to a problem? Please describe and/or link to a bug issue.

pre-commit install --install-hook
all other hook are ready to be used , once we run the command

Expected Behavior

pre-commit install --install-hook
run helm-docs

Current Behavior

pre-commit install --install-hook
run helm-docs

Helm Docs................................................................Failed

  • hook id: helm-docs
  • exit code: 1

Possible Solution

wget the rev binary, or add it directly into the repo for each release ?

Alternatives you've considered

.

Further Information

.

@DrummyFloyd DrummyFloyd added enhancement New feature or request triage Issues that need to be triaged and categorized labels Feb 29, 2024
@DrummyFloyd
Copy link
Author

might be the solution ?
=>
pre-commit/pre-commit#3020

@norwoodj
Copy link
Owner

norwoodj commented Mar 2, 2024

It's a nice idea. I'd look at a PR if you want to implement a cross-platform way of installing the binary in the script, or use some pre-commit feature to do so.

@DrummyFloyd
Copy link
Author

to be be honest, it would be quite easy , if i know how to retrieve the ref key from pre-commit,
but didn't find any documenttaion about this, need to dig into the code of pre-commit to check if it's possible
like this we will keep the script , light as possible , you will have somethign like this

if Not preset; then
wget <url> $REF
mv <bniary> ./helm-docs
else
./helm-docs
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issues that need to be triaged and categorized
Projects
None yet
Development

No branches or pull requests

3 participants