Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Spellcheck doesn't work #1173

Closed
avishaan opened this issue Jun 1, 2020 · 5 comments
Closed

MacOS Spellcheck doesn't work #1173

avishaan opened this issue Jun 1, 2020 · 5 comments
Labels
enhancement New feature or request maybe It's unsure whether this should be implemented or not

Comments

@avishaan
Copy link

avishaan commented Jun 1, 2020

  • MacOS 10.15.4 (19E287):
  • 1.8.4:

Current behavior

Incorrectly spell a word in a note. The OS spellcheck won't pick up the spelling error

Expected behavior

I expect the built-in MacOS spell check to continue to working. I know there is a thread about built in notable spell checking but I am just talking about the MacOS spell check that shows up in any text field

Side note: the normal mac text context menu doesn't work in general

@fabiospampinato fabiospampinato added enhancement New feature or request maybe It's unsure whether this should be implemented or not labels Jun 1, 2020
@fabiospampinato
Copy link
Member

I'm not sure we should spell-check inputs too 🤔

@avishaan
Copy link
Author

avishaan commented Jun 1, 2020

I don't think we need to let macos spellcheck the inputs but we should be letting macos spellcheck the markdown field

@avishaan
Copy link
Author

avishaan commented Jun 1, 2020

As an example, in any mac text field the built in macos spell checker will underline the incorrect spelling such as my screenshot below
image

however in notable this doesn't seem to be working when entering markdown

@avishaan
Copy link
Author

avishaan commented Jun 1, 2020

here is a relevant github issue in the electron repo electron/electron#20692 and here is one of the original discussions about it electron/electron#3189 (make sure you read toward the bottom as it is a very old issue)

@fabiospampinato
Copy link
Member

I don't think we need to let macos spellcheck the inputs but we should be letting macos spellcheck the markdown field

Let's track this in the main issue about spell checking then: #108

We can't just make macOS spell-check the editor, that's more like a webpage than an input really, and we need to sort of reimplement the spell checking anyway because the app needs to run in the browser too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe It's unsure whether this should be implemented or not
Development

No branches or pull requests

2 participants