Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large notes are not exported successfully to PDF #979

Closed
fabiospampinato opened this issue Jan 15, 2020 · 1 comment
Closed

Large notes are not exported successfully to PDF #979

fabiospampinato opened this issue Jan 15, 2020 · 1 comment
Labels
bug Something isn't working exporting Issue related to exporting upstream This issue depends on an upstream dependency

Comments

@fabiospampinato
Copy link
Member

  • OS Version: macOS 10.14
  • Notable Version: 1.8.2

Current behavior

Attempting to export PDFs whose corresponding HTML, including base64-encoded images, is larger than 2MB will fail.

Expected behavior

It should work.

The issue is that we are putting that HTML into a data url to workaround an Electron bug, but data urls have a size limit of 2MB in Chromium/Electron. electron/electron#18093 (comment)
@fabiospampinato fabiospampinato added bug Something isn't working exporting Issue related to exporting upstream This issue depends on an upstream dependency labels Jan 15, 2020
@fabiospampinato fabiospampinato changed the title Large Large notes are not exported successfully to PDF Jan 15, 2020
This was referenced Jan 16, 2020
Closed
Closed
@fabiospampinato
Copy link
Member Author

I just fixed this, the fix will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working exporting Issue related to exporting upstream This issue depends on an upstream dependency
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabiospampinato