Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows user interested in using and participating #17

Open
MonsieurMan opened this issue Oct 3, 2019 · 1 comment
Open

Windows user interested in using and participating #17

MonsieurMan opened this issue Oct 3, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MonsieurMan
Copy link

MonsieurMan commented Oct 3, 2019

Hello there ! I'm tired too of apollo client being so slow at generating types and them not responding issues.

I'd really like to use this project and participate also but I see windows's not supported, would you mind me landing a PR to add support ?

I also have other needs as an angular + apollo user, see #18.

If I understand right, it would need to:

  • Add windows build to the CI
  • Make the install process work on windows
    • Use a npm package only for windows for unzipping instead of tar command ?
@dairyisscary dairyisscary added enhancement New feature or request good first issue Good for newcomers labels Mar 14, 2020
@dairyisscary
Copy link
Collaborator

dairyisscary commented Mar 14, 2020

@MonsieurMan I'm so sorry I didn't see your issue/PR until just now. I never got any notifications, that i noticed at least. I must not have email notifications set up properly or something. The irony of your complaint against apollo.

As opposed to the template string support, I'm much more interested in the window support and would love your help, if you're still interested!

I think the steps you named there are spot on:

  • Hopefully the notarize/cross-rust docker image is already capable of building windows (unsure if it is). Let me know if you need the Dockerfile for this image if you want to build it or if it needs to be modified in some way. In any case, you'll just have to add another compile command to the build binary step.
  • Obviously, make sure it gets attached to the github release (in an archive type that works for windows -- or maybe just the exe directly?).
  • Add support to pkg/npm to download the windows version from github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants