We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notation CLI
This is a requirement about scanning and checking whether code changes contain correct license headers and their dependencies in each PRchecking
We want to check license headers and dependencies' licenses for Notation. This is important to align with the CNCF open-source compliance policy.
SkyWalking-Eyes might be a good tool to implement the license header check and can be integrated into the GitHub Actions workflow.
It will scan and check whether code changes contain correct license headers and their dependencies in each PR (CI). There is an example in ORAS: https://github.com/oras-project/oras/actions/runs/4912774337/jobs/8772170747
N/A
Two things we need to complete for this issue:
The text was updated successfully, but these errors were encountered:
I have noticed it has been given write permission to run it, will it be fine to give it?
https://github.com/oras-project/oras/blob/3ff15bbcb516fe5f3a766fb37ac0d92efe15c98e/.github/workflows/license-checker.yml#L26-L28
There is also an official action by GitHub which can perform licence check: https://github.com/actions/dependency-review-action#configuration-options along with other features. But there seems to be an open issue which can cause problems actions/dependency-review-action#459
Thank you!
The link the to Skywalking Action is broken https://github.com/marketplace/actions/license-eye correct link-> https://github.com/marketplace/actions/license-eye-header
Sorry, something went wrong.
@FeynmanZhou have you considered creating a NOTICE file to include the dependency licenses?
NOTICE
cc @toddysm
@FeynmanZhou have you considered creating a NOTICE file to include the dependency licenses? cc @toddysm
@zr-msft Not yet. Only Apache software has a requirement for creating a NOTICE file https://www.apache.org/legal/src-headers.html#notice. CNCF seems don't have such a requirement to include a NOTICE file for the project.
chore: add license header to files and github action workflow to chec…
57a0a6e
…k license (#739) Resolves #706 Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Two-Hearts
Successfully merging a pull request may close this issue.
What is the areas you would like to add the new feature to?
Notation CLI
Is your feature request related to a problem?
This is a requirement about scanning and checking whether code changes contain correct license headers and their dependencies in each PRchecking
What solution do you propose?
We want to check license headers and dependencies' licenses for Notation. This is important to align with the CNCF open-source compliance policy.
SkyWalking-Eyes might be a good tool to implement the license header check and can be integrated into the GitHub Actions workflow.
It will scan and check whether code changes contain correct license headers and their dependencies in each PR (CI). There is an example in ORAS: https://github.com/oras-project/oras/actions/runs/4912774337/jobs/8772170747
What alternatives have you considered?
N/A
Any additional context?
Two things we need to complete for this issue:
The text was updated successfully, but these errors were encountered: