Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kqueue debug messages #356

Closed
netthier opened this issue Sep 1, 2021 · 1 comment · Fixed by #357
Closed

kqueue debug messages #356

netthier opened this issue Sep 1, 2021 · 1 comment · Fixed by #357
Labels

Comments

@netthier
Copy link
Contributor

netthier commented Sep 1, 2021

System details

  • OS/Platform name and version: FreeBSD 13.0-RELEASE-p3
  • Rust version (if building from source): rustc --version: rustc 1.54.0 (a178d0322 2021-07-26)
  • Notify version (or commit hash if building from git): notify-5.0.0-pre.12
  • If you're coming from a project that makes use of Notify, what it is, and a link to the downstream issue if there is one: Trunk (a WASM web application bundler for Rust)
  • Filesystem type and options: ZFS

What you did (as detailed as you can)

I tried using Trunk to compile and serve a WebAssembly binary

What you expected

Clean console output.

What happened

The trunk output contained a lot of debug messages originating from notify, here's an example:

[/home/lmt/.cargo/registry/src/github.com-1ecc6299db9ec823/notify-5.0.0-pre.12/src/kqueue.rs:145] &event = Event {
    ident: Filename(
        16,
        "/path/to/project/frontend/dist",
    ),
    data: Vnode(
        Write,
    ),
}

The reason for these is quite obviously the dbg!() statement here
It makes trunk's output almost unreadable, so I'm wondering if it's really necessary.

@0xpr03 0xpr03 added the A-bug label Sep 1, 2021
@0xpr03
Copy link
Member

0xpr03 commented Sep 1, 2021

That is definitely an oversight by me reviewing #335, will fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants