Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release version v5 #405

Closed
samuelcolvin opened this issue May 17, 2022 · 1 comment
Closed

Please release version v5 #405

samuelcolvin opened this issue May 17, 2022 · 1 comment

Comments

@samuelcolvin
Copy link
Contributor

Thanks so much for notify, it's great and I've had a really great experience wrapping it for the watchfiles python package.

Unfortunately, the continued use of pre-releases is making notify significantly harder to use than it should be.

Please could you release version 5.

In particular as per rust's dependency resolution logic on pre-releases:

Cargo allows "newer" pre-releases to be used automatically. For example, if 1.0.0-beta is published, then a requirement foo = "1.0.0-alpha" will allow updating to the beta version.

This means that we can't effectively lock the notify dependency to a specific pre-release.

As per samuelcolvin/watchfiles#144 and conda-forge/watchfiles-feedstock#5 this has just bitten us since conda forge decided to use 5.0.0-pre.15 which is incompatible with 5.0.0-pre.14 (which the package had been targeting) because PollWatcher::with_delay was replaced with PollWatcher::with_config. To make matters worse, this breaking change was not noted in the release notes.

@JohnTitor
Copy link
Member

Duplicate of #249, please continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants