Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support action name attribute #526

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

larmitage-bjss
Copy link
Contributor

To be merged after #525

Added an option to include the name of the action as a header, defaulting to not show

This is so that when we add functionality for documenting a workflow there is a header at the top as a workflow doesn't have a description

@npalm npalm changed the title GH-240 add name header feat: support action name attribute Feb 14, 2024
Copy link
Owner

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larmitage-bjss Thx! The PR looks good, took the freedom to rebase the PR. Have made one request for change.

src/cli.ts Outdated Show resolved Hide resolved
@larmitage-bjss
Copy link
Contributor Author

If it's two characters the shorthand needs two dashes, so I've chosen just -n. Ready for re-review please

Copy link
Owner

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for you great contribution

@npalm npalm merged commit 0e99848 into npalm:main Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants