allow individual styling in multiBar.create()
#136
Conversation
on `multiBar.create()`, allow changing the following style options: * `barCompleteChar` * `barIncompleteChar`
|
hi @Araxeus , thanks for your contribution. i can confirm the behaviour but like to prefer a more comprehensive solution: some more elements of the options initialization has to be moved into the btw. don't commit changes to meta files like |
And why is that? I'm using yarn v3 and installing creates Without adding them to the Also what reason would there ever be not to modify
As you wish, but I personally think that since I spent time on this fix, and you want to use it - it's good etiquette to merge then create a fix commit Or you could just tell me what changes do you request, and I'll try doing it myself |
|
a pull request should only contain changes to required files.. |
|
added to 6c75740 |
|
Anyways, thank you for merging the feature 🎉 I now see that I forgot to also update the auto padding option |
|
And i also just wanted to say, if it was my first time contributing to open source, I dont think I would have been very encouraged by the fact that you "discarded" my work It's not my first rodeo, so I understand where you're coming from, I'm just saying its not a very welcoming behavior The first pull request I ever made was met with excitement and encouragement, which made me continue on the open source path :) Just food for thoughts @AndiDittrich |
|
sry for this but on the other hand you've to understand that it's very time consuming to give everybody a crash course howto contribute, fix their first time mistakes etc. didn't have time for that...i know that the standard git workflow is complex for beginners. fixing issues directly is much more efficient especially if other changes needs to be applied. so don't worry |
on
multiBar.create(), allow changing the following style options:barCompleteCharbarIncompleteCharBecause I just wanted to have a top bar that is a general status, and the other ones are the running processes