Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Never bundle when saving as peer/peerOptional #255

Merged
merged 1 commit into from Mar 23, 2021
Merged

Never bundle when saving as peer/peerOptional #255

merged 1 commit into from Mar 23, 2021

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Mar 19, 2021

There's a bit of logic in npm/cli that sets the saveBundle option to
false based on the various --save-xyz flags. It is easier and safer
to just never bundle if we're saving a peer dep, in the one place where
that decision is made.

References

@isaacs
Never bundle when saving as peer/peerOptional
22b2d13 
There's a bit of logic in npm/cli that sets the `saveBundle` option to
false based on the various `--save-xyz` flags.  It is easier and safer
to just never bundle if we're saving a peer dep, in the one place where
that decision is made.

PR-URL: #255
Credit: @isaacs
Close: #255
@isaacs isaacs closed this in 22b2d13 Mar 23, 2021
@isaacs isaacs merged commit 22b2d13 into main Mar 23, 2021
This was referenced Mar 23, 2021
Merged
Closed
@wraithgar wraithgar deleted the isaacs/never-bundle-peers branch April 22, 2021 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@isaacs