Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deduplicate move operations #203

Merged
merged 1 commit into from May 16, 2023
Merged

fix: deduplicate move operations #203

merged 1 commit into from May 16, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented May 13, 2023 •
edited

@wraithgar wraithgar requested a review from a team as a code owner May 13, 2023 01:23
nlf
nlf previously requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as requested changes until we can hash out if a Map or object is better here

lib/content/write.js Outdated Show resolved Hide resolved
fritzy
fritzy requested changes May 15, 2023
View reviewed changes
lib/content/write.js Show resolved Hide resolved
@wraithgar wraithgar requested review from fritzy and nlf May 15, 2023 23:16
@fritzy fritzy dismissed nlf’s stale review May 16, 2023 16:17

last day, resolved in conversation

@wraithgar wraithgar merged commit 988d77a into main May 16, 2023
17 checks passed
@wraithgar wraithgar deleted the gar/promise-inflight branch May 16, 2023 16:19
@github-actions github-actions bot mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy fritzy approved these changes

@nlf nlf Awaiting requested review from nlf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[task] re-introduce async duplication prevention
3 participants
@wraithgar @fritzy @nlf