feat: expose index.insert, implement and expose index.compact #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
converted to draft while i work on make-fetch-happen so i can make sure that this api surface is all i need. will either update this pull request or switch it back to ready to merge based on that work. |
isaacs
reviewed
May 18, 2021
|
This looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements two new features that will allow us to both compact existing cache indexes and manually append new indexes without having to go through the current hoops of reading the existing content and writing it back.
I elected to only export the two methods that I intend to consume in make-fetch-happen in order to keep the public API of this module to a minimum, allowing us to avoid breaking changes if some internals are refactored.
References
Related to npm/statusboard#357