From 32ccd3c2767a14198a1803f04e747ef848f7c938 Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Wed, 3 Nov 2021 14:57:22 -0700 Subject: [PATCH] chore: remove usage of unnecessary util.promisify This is safe to do now that we've dropped node 10 support. PR-URL: https://github.com/npm/cli/pull/3988 Credit: @lukekarrys Close: #3988 Reviewed-by: @wraithgar --- lib/utils/reify-finish.js | 4 +--- test/lib/utils/reify-finish.js | 8 -------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/lib/utils/reify-finish.js b/lib/utils/reify-finish.js index 1c02b93a4129..a9ac4c61f5b8 100644 --- a/lib/utils/reify-finish.js +++ b/lib/utils/reify-finish.js @@ -1,8 +1,6 @@ const reifyOutput = require('./reify-output.js') const ini = require('ini') -const util = require('util') -const fs = require('fs') -const { writeFile } = fs.promises || { writeFile: util.promisify(fs.writeFile) } +const { writeFile } = require('fs').promises const {resolve} = require('path') const reifyFinish = async (npm, arb) => { diff --git a/test/lib/utils/reify-finish.js b/test/lib/utils/reify-finish.js index bbe8a3d99021..b66d5bcd3b53 100644 --- a/test/lib/utils/reify-finish.js +++ b/test/lib/utils/reify-finish.js @@ -76,11 +76,3 @@ t.test('should write if everything above passes', async t => { const data = fs.readFileSync(`${path}/npmrc`, 'utf8').replace(/\r\n/g, '\n') t.matchSnapshot(data, 'written config') }) - -t.test('works without fs.promises', async t => { - t.doesNotThrow(() => t.mock('../../../lib/utils/reify-finish.js', { - fs: { ...fs, promises: null }, - '../../../lib/npm.js': npm, - '../../../lib/utils/reify-output.js': reifyOutput, - })) -})