From 3c9a589b004fa828a304abaf52d1d781710e1143 Mon Sep 17 00:00:00 2001 From: kumavis Date: Tue, 2 Mar 2021 10:53:36 +0800 Subject: [PATCH] feat/explain: show when an edge is a bundled edge PR-URL: https://github.com/npm/cli/pull/2807 Credit: @kumavis Close: #2807 Reviewed-by: @ruyadorno --- lib/utils/explain-dep.js | 3 ++- tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js | 4 ++-- test/lib/utils/explain-dep.js | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/utils/explain-dep.js b/lib/utils/explain-dep.js index 213493c654b08..c01bc780bfb47 100644 --- a/lib/utils/explain-dep.js +++ b/lib/utils/explain-dep.js @@ -86,9 +86,10 @@ const explainDependents = ({ name, dependents }, depth, color) => { return str.split('\n').join('\n ') } -const explainEdge = ({ name, type, from, spec }, depth, color) => { +const explainEdge = ({ name, type, bundled, from, spec }, depth, color) => { const { bold } = color ? chalk : nocolor return (type === 'prod' ? '' : `${colorType(type, color)} `) + + (bundled ? `${colorType('bundled', color)} ` : '') + `${bold(name)}@"${bold(spec)}" from ` + explainFrom(from, depth, color) } diff --git a/tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js b/tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js index 6d169bca69806..7e77081f9d636 100644 --- a/tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js +++ b/tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js @@ -24,13 +24,13 @@ manydep@1.0.0 exports[`test/lib/utils/explain-dep.js TAP bundled > explain color deep 1`] = ` bundle-of-joy@1.0.0 bundled node_modules/bundle-of-joy - prod-dep@"1.x" from the root project + bundled prod-dep@"1.x" from the root project ` exports[`test/lib/utils/explain-dep.js TAP bundled > explain nocolor shallow 1`] = ` bundle-of-joy@1.0.0 bundled node_modules/bundle-of-joy - prod-dep@"1.x" from the root project + bundled prod-dep@"1.x" from the root project ` exports[`test/lib/utils/explain-dep.js TAP bundled > print color 1`] = ` diff --git a/test/lib/utils/explain-dep.js b/test/lib/utils/explain-dep.js index 1b8c4ae3805cf..1fee6105081e9 100644 --- a/test/lib/utils/explain-dep.js +++ b/test/lib/utils/explain-dep.js @@ -107,6 +107,7 @@ const cases = { type: 'prod', name: 'prod-dep', spec: '1.x', + bundled: true, from: { location: '/path/to/project', },