Skip to content

Commit 454c7dd

Browse files
isaacsclaudiahdz
authored andcommittedNov 14, 2019
test: fix git configs for git 2.23 and above
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
1 parent 5c3b327 commit 454c7dd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed
 

‎test/common-tap.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ exports.makeGitRepo = function (params, cb) {
193193
git.chainableExec(['config', 'user.name', user], opts),
194194
git.chainableExec(['config', 'user.email', email], opts),
195195
// don't time out tests waiting for a gpg passphrase or 2fa
196-
git.chainableExec(['config', 'commit.gpgsign', 'false'], opts),
196+
git.chainableExec(['config', 'commit.gpgSign', 'false'], opts),
197+
git.chainableExec(['config', 'tag.gpgSign', 'false'], opts),
197198
git.chainableExec(['config', 'tag.forceSignAnnotated', 'false'], opts),
198199
git.chainableExec(['add'].concat(added), opts),
199200
git.chainableExec(['commit', '-m', message], opts)

0 commit comments

Comments
 (0)
Please sign in to comment.