From 70f54dcb5693b301c6b357922b7e8d16b57d8b00 Mon Sep 17 00:00:00 2001 From: Henrik Gemal Date: Wed, 28 Aug 2019 09:37:57 +0200 Subject: [PATCH] Make OK more consistent PR-URL: https://github.com/npm/cli/pull/241 Credit: @gemal Close: #241 Reviewed-by: @isaacs --- lib/doctor/check-ping.js | 2 +- test/tap/doctor.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/doctor/check-ping.js b/lib/doctor/check-ping.js index 70db255480c3..58f14fe69e1e 100644 --- a/lib/doctor/check-ping.js +++ b/lib/doctor/check-ping.js @@ -8,7 +8,7 @@ function checkPing (cb) { if (err && err.code && err.code.match(/^E\d{3}$/)) { return cb(null, [err.code.substr(1)]) } else { - cb(null, [200, 'OK']) + cb(null, [200, 'ok']) } }) } diff --git a/test/tap/doctor.js b/test/tap/doctor.js index 9285518c2e10..9a1b42cdd536 100644 --- a/test/tap/doctor.js +++ b/test/tap/doctor.js @@ -92,7 +92,7 @@ t.test('npm doctor', function (t) { npm.commands.doctor({'node-url': node_url}, true, function (e, list) { t.ifError(e, 'npm loaded successfully') t.same(list.length, 9, 'list should have 9 prop') - t.same(list[0][1], 'OK', 'npm ping') + t.same(list[0][1], 'ok', 'npm ping') t.same(list[1][1], 'v' + npm.version, 'npm -v') t.same(list[2][1], process.version, 'node -v') t.same(list[3][1], common.registry + '/', 'npm config get registry') @@ -113,7 +113,7 @@ t.test('npm doctor works without registry', function (t) { npm.commands.doctor({'node-url': node_url}, true, function (e, list) { t.ifError(e, 'npm loaded successfully') t.same(list.length, 9, 'list should have 9 prop') - t.same(list[0][1], 'OK', 'npm ping') + t.same(list[0][1], 'ok', 'npm ping') t.same(list[1][1], 'v' + npm.version, 'npm -v') t.same(list[2][1], process.version, 'node -v') t.same(list[3][1], '', 'no registry, but no crash')