From 7898f23ea16bc09cec040c880effb36b8eb3bb44 Mon Sep 17 00:00:00 2001 From: isaacs Date: Fri, 29 Jan 2021 09:53:34 -0800 Subject: [PATCH] ignore the sort in help-search more broadly It turns out that the other stuff in those objects might also be in random order, so this is still triggering CI coverage failures, albeit more rarely than it used to. Just ignore the whole sort function. It's fine, we implicitly assert on the sortedness in the test, so we know that it is doing its job. PR-URL: https://github.com/npm/cli/pull/2574 Credit: @isaacs Close: #2574 Reviewed-by: @nlf --- lib/help-search.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/help-search.js b/lib/help-search.js index d60ef5b4ba89f..d2a1818060b21 100644 --- a/lib/help-search.js +++ b/lib/help-search.js @@ -135,12 +135,11 @@ const searchFiles = async (args, data, files) => { // coverage is ignored here because the contents of results are // nondeterministic due to either glob or readFiles or Object.entries - return results.sort((a, b) => + return results.sort(/* istanbul ignore next */ (a, b) => a.found.length > b.found.length ? -1 : a.found.length < b.found.length ? 1 : a.totalHits > b.totalHits ? -1 : a.totalHits < b.totalHits ? 1 - /* istanbul ignore next */ : a.lines.length > b.lines.length ? -1 : a.lines.length < b.lines.length ? 1 : 0).slice(0, 10)