fix: properly catch missing url opener error (#6951)

wraithgar · web-flow · commit dce3b0896ba8 · 2023-11-06T08:46:48.000-08:00
diff --git a/lib/utils/open-url.js b/lib/utils/open-url.js
@@ -39,7 +39,7 @@ const open = async (npm, url, errMsg, isFile) => {
   const command = browser === true ? null : browser
   await promiseSpawn.open(url, { command })
     .catch((err) => {
-      if (err.code !== 'ENOENT') {
+      if (err.code !== 127) {
         throw err
       }
 
diff --git a/test/lib/utils/open-url.js b/test/lib/utils/open-url.js
@@ -124,7 +124,7 @@ t.test('prints where to go when given browser does not exist', async t => {
   const { openerUrl, openerOpts, joinedOutput } = await mockOpenUrl(t,
     ['https://www.npmjs.com', 'npm home'],
     {
-      openerResult: Object.assign(new Error('failed'), { code: 'ENOENT' }),
+      openerResult: Object.assign(new Error('failed'), { code: 127 }),
     }
   )
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ const open = async (npm, url, errMsg, isFile) => {`
`39`	`39`	`const command = browser === true ? null : browser`
`40`	`40`	`await promiseSpawn.open(url, { command })`
`41`	`41`	`.catch((err) => {`
`42`		`- if (err.code !== 'ENOENT') {`
	`42`	`+ if (err.code !== 127) {`
`43`	`43`	`throw err`
`44`	`44`	`}`
`45`	`45`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ t.test('prints where to go when given browser does not exist', async t => {`
`124`	`124`	`const { openerUrl, openerOpts, joinedOutput } = await mockOpenUrl(t,`
`125`	`125`	`['https://www.npmjs.com', 'npm home'],`
`126`	`126`	`{`
`127`		`- openerResult: Object.assign(new Error('failed'), { code: 'ENOENT' }),`
	`127`	`+ openerResult: Object.assign(new Error('failed'), { code: 127 }),`
`128`	`128`	`}`
`129`	`129`	`)`
`130`	`130`