Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
6
contributors
Commits on Nov 1, 2022
-
fix: use hosted-git-info to parse registry urls (#5758)
Previously this was using `new URL` which would fail on some urls that `hosted-git-info` is able to parse. But if we still get a url that can't be parsed, we now set it to be removed from the tree instead of erroring. Fixes: #5278
-
chore: rewrite
scripts/with javascriptGoals of this rewrite: - Better portability of scripts to anywhere we can run `node` and no reliance on `make` or other tools - More code inside `scripts/` and less inside of CI workflows to allow for easier local testing - Reuse the same scripts for similar workflows (eg `publish` and `smoke-publish`) Future goals: - Allow testing of `scripts` Some highlights of the new scripts: `scripts/create-node-pr.js` - This now operates on cloned copy of the base repo that is pushed to our fork, so we no longer need to manually sync our fork. - Uses the published registry tarball for as much of the PR as possible, falling back to including local files from source. This will enable for easier migration to eventually only using the tarball contents. `scripts/publish.js` - Replaces `make publish` - Will publish all workspaces that need to be published, before publishing the CLI. - Makes running tests an optional part of the script, since CI now runs the tests. - Can optionally only pack the tarball, for use in CI to test installing the tarball. `scripts/util.js` - Shared utilities for spawning commands including helpers for `npm` and `gh`. - Common interface for running, parsing args, logging, and debugging of scripts.
-
-
chore: remove mdx from docs build
We will be updating to mdx@2 soon which is esm only, but built in to Gatsby. Due to the new documentation build process here and in `npm/documentation`, there is much less need for us to verify all our docs here. Therefore, it is best to remove this dependency now to avoid needing to update it here at the same time as the docs site.
-
-
This moves all the dependencies of the `docs/` workspace to dev deps. I had originally moved them out of devDeps as part of #5309, but this seems to go against the grain of other tooling. We would have to special case both `audit` and `licensee` to run on a custom subset of our dependency tree. Maybe one day when all tools can be piped the output of an `npm query` this will be possible. It would be nice if we could only audit dependencies that are bundled as part of the CLI. But for now it's easier to move these to devDeps and then reinstall only the docs workspace after pruning during the publish step.
-
-
-
chore: automatically remove ignored node_modules files
Previously it would report the errors and require rerunning the script. It's been safe enough that we know automatically remove the files. We then run the `git ls-files` command again to make sure they were all removed. Only if any are left do we error with a message requiring a manual fix.
-
chore: remove install.sh script
The readme already points to the canonical url (https://www.npmjs.com/install.sh) which is sourced from https://github.com/npm/npm-install-script so this file does not need to live in this repo anymore.
Commits on Nov 2, 2022
-
-
deps: remove opener, @npmcli/promise-spawn@6.0.1, @npmcli/run-script@…
…5.1.1, @npmcli/git@4.0.3, pacote@15.0.5, which@3.0.0
-
-
-
-
fix: don't set
stdioStringfor any spawn/run-script callsThese libraries now return strings by default which is what we always want in the CLI for error reporting. Fixes #5766
-
-
-
-
-
-
-
-
There are no files selected for viewing