Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm profile refactor #2373

Merged
merged 1 commit into from Dec 18, 2020
Merged

fix: npm profile refactor #2373

merged 1 commit into from Dec 18, 2020

Conversation

ruyadorno
Copy link
Collaborator

Refactor npm profile and added full test coverage, also fixed a couple of minor issues encountered, in summary:

  • Fixes using --otp config option in npm profile enable-2fa
  • Prevents trying to enable 2fa if no user is logged in
  • Setting email should not require password
  • Add test/lib/profile.js tests
  • Async/await lib/profile.js refactor and more
  • Fixes: v7(tests): profile statusboard#164

@ruyadorno ruyadorno requested a review from a team as a code owner December 17, 2020 17:11
@ruyadorno ruyadorno self-assigned this Dec 17, 2020
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 17, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 21 milestone Dec 17, 2020
ljharb
ljharb reviewed Dec 17, 2020
View reviewed changes
lib/profile.js Outdated Show resolved Hide resolved
lib/profile.js Outdated Show resolved Hide resolved
lib/profile.js Outdated Show resolved Hide resolved
@ruyadorno
Copy link
Collaborator Author

Thanks for the review @ljharb! 🙌

nlf
nlf approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruyadorno @isaacs
fix: npm profile refactor
cba3341 
- Fixes using `--otp` config option in `npm profile enable-2fa`
- Prevents trying to enable 2fa if no user is logged in
- Setting email should not require password
- Add `test/lib/profile.js` tests
- Async/await `lib/profile.js` refactor and more

- Fixes: npm/statusboard#164

PR-URL: npm#2373
Credit: @ruyadorno
Close: npm#2373
Reviewed-by: @isaacs
@isaacs isaacs changed the base branch from latest to release/v7.3.0 December 18, 2020 20:02
@isaacs isaacs merged commit cba3341 into npm:release/v7.3.0 Dec 18, 2020
@ruyadorno ruyadorno mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@Sanan1980 Sanan1980 Sanan1980 left review comments

@nlf nlf nlf approved these changes

Assignees

@ruyadorno ruyadorno

Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 21
Development

Successfully merging this pull request may close these issues.

v7(tests): profile
5 participants
@ruyadorno @ljharb @nlf @Sanan1980 @isaacs