fix: publish --dry-run require login & publishConfig loaded after registry check #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I split the last fix as a separate PR? Currently the coverage error will affect other PR made in this year. |
darcyclarke
added
Release 7.x
|
Can you please remove the dry-run and birthday tests, since they're unrelated to the issue of merging in Also, this needs a test that fails without the patch, and passes with the patch. Thanks! |
ruyadorno
added
pr: needs tests
|
Sure, I see there's 7.4.0, will rebase & change the code. |
dr-js
force-pushed
the
fix-publish-dry-run
branch
from
7bd1549
to
d43156e
Compare
darcyclarke
removed
the
release: next
|
@dr-js Thank you for doing this! Let me know if I can assist in any way. |
|
@ruyadorno There is one test added for the fix, should I add some other type of tests for this? |
ruyadorno
added
release: next
nlf
force-pushed
the
fix-publish-dry-run
branch
from
d43156e
to
d2f8af2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix(already fixed)publish --dry-runwith v7.3.0 will require login (ENEEDAUTH).Fix
publishConfigfrompackage.jsonloaded after the registry check.This PR delayed publish login check till config merge (from the code should wait for 1 more file read or pacote manifest load), and added publish read registry only from publishConfig test.
References
Fixes #2411
Related PR also fix dry-run #2422