Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pay attention to --ignore-scripts #2455

Merged
merged 1 commit into from Jan 7, 2021

Conversation

wraithgar
Copy link
Member

npm ci does not enforce the --ignore-scripts option. Now it does.

Also added a test for npm install --ignore-scripts

References

Closes #2434

@wraithgar wraithgar requested a review from a team as a code owner January 7, 2021 17:15
@npm-deploy-user
Copy link

npm-deploy-user commented Jan 7, 2021

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 42.7s✅🐌 39.5s 45.8s🛑 34.5s 35.2s✅🐌 28.1s 28.4s✅🐌 33.5s 37.6s🛑
repeat install 9.6s 3.1s 8.6s 3.6s 8.3s 2.5s 7.7s 1.6s 9.1s 2.7s
with warm cache 32.3s 27s 33.8s 29.2s 31.3s 20.2s 23.4s 17.3s 29.1s 19s
with node_modules 9.2s 6.1s 8.6s 4.6s 9s 3.4s 7.8s 1.9s 9.4s 5.6s
with lockfile 32.6s 30s 31s 31.2s✅🐌 29s 23.3s 21.7s 17.1s 27.4s 25.9s
with warm cache and node_modules 9.3s 3.4s 7.9s 3.6s 8.4s 3s 7.6s 1.8s 9.2s 3s
with warm cache and lockfile 24.7s 10.2s 26.3s 13.5s 24.3s 8.4s 17.8s 5.7s 21.3s 7.5s
with node_modules and lockfile 10.1s 5.5s 9.8s 4.2s 8.6s 3.1s 7.8s 1.7s 9.7s 5.3s

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Jan 7, 2021
Added a test for install too for this specific condition

PR-URL: #2455
Credit: @wraithgar
Close: #2455
Reviewed-by: @isaacs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--ignore-scripts flag is being ignored by npm ci
6 participants