Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] $(npm version patch) no longer returns vX.Y.Z, but only X.Y.Z #2653

Closed
asgerjensen opened this issue Feb 8, 2021 · 2 comments · Fixed by #2718
Closed

[BUG] $(npm version patch) no longer returns vX.Y.Z, but only X.Y.Z #2653

asgerjensen opened this issue Feb 8, 2021 · 2 comments · Fixed by #2718
Assignees
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release

Comments

@asgerjensen
Copy link

asgerjensen commented Feb 8, 2021

This may have been on purpose, but i do not see the behavior change listed under breaking changes.
https://blog.npmjs.org/post/626173315965468672/npm-v7-series-beta-release-and-semver-major

Current Behavior:

VERSION=$(npm version patch)
set tag to v1.0.1, but VERSION is 1.0.1

Expected Behavior:

NPM 6 behavior:

VERSION=$(npm version patch)
set tag to v1.0.1, and VERSION is v1.0.1

Steps To Reproduce:

  • npm init
  • echo $(npm version patch)

Environment:

Node 10, Node 15, npm 7.5.2
Ubuntu and Mac Catalina.

@asgerjensen asgerjensen added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Feb 8, 2021
@nlf nlf removed the Needs Triage needs review for next steps label Feb 17, 2021
@nlf nlf self-assigned this Feb 17, 2021
@nlf
Copy link
Contributor

nlf commented Feb 17, 2021

good catch! #2718 will fix this in the next release

@nlf
Copy link
Contributor

nlf commented Feb 22, 2021

this is fixed in npm@7.5.5 which was just published today

@nlf nlf closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants