Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clobber defined 'env' script with default #2655

Closed
wants to merge 2 commits into from
Closed

Do not clobber defined 'env' script with default #2655

wants to merge 2 commits into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Feb 8, 2021

References

@isaacs isaacs requested a review from a team as a code owner February 8, 2021 23:19
ljharb
ljharb approved these changes Feb 8, 2021
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this lgtm, why would npm run env ever work if npm env doesn't, even if there's no script?

ljharb added a commit to enzymejs/enzyme that referenced this pull request Feb 9, 2021
@ljharb
[Tests] avoid npm run env bug in npm 7
fba6a04 
Fixed by npm/cli#2655
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 11, 2021
@wraithgar wraithgar closed this in ef687f5 Feb 12, 2021
@ruyadorno ruyadorno mentioned this pull request Feb 12, 2021
Closed
@ruyadorno ruyadorno mentioned this pull request Feb 24, 2021
Closed
web-developer77 added a commit to web-developer77/react-enzyme that referenced this pull request Jul 22, 2021
@web-developer77
[Tests] avoid npm run env bug in npm 7
c1bc6eb 
Fixed by npm/cli#2655
@nlf nlf deleted the isaacs/do-not-clobber-env-run-script branch March 28, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaacs @ljharb @darcyclarke